Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Enable Decorators #17828

Merged
merged 2 commits into from
Apr 1, 2019
Merged

[FEAT] Enable Decorators #17828

merged 2 commits into from
Apr 1, 2019

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Mar 31, 2019

Enables decorators and updates the API docs for computed properties, injections, macros, and @action.

mike-north
mike-north reviewed Mar 31, 2019
View reviewed changes
packages/@ember/-internals/metal/lib/computed.ts Outdated Show resolved Hide resolved
packages/@ember/-internals/metal/lib/computed.ts Outdated Show resolved Hide resolved
packages/@ember/-internals/metal/lib/computed.ts Outdated Show resolved Hide resolved
packages/@ember/object/index.js Show resolved Hide resolved
packages/@ember/object/lib/computed/reduce_computed_macros.js Show resolved Hide resolved
packages/@ember/object/lib/computed/reduce_computed_macros.js Outdated Show resolved Hide resolved
packages/@ember/object/lib/computed/reduce_computed_macros.js Outdated Show resolved Hide resolved
packages/@ember/object/lib/computed/reduce_computed_macros.js Outdated Show resolved Hide resolved
packages/@ember/object/lib/computed/reduce_computed_macros.js Outdated Show resolved Hide resolved
@auvipy
Copy link

auvipy commented Apr 1, 2019

Looks fantastic! thanks for the great work!

@rwjblue rwjblue merged commit 85de05f into master Apr 1, 2019
@rwjblue rwjblue deleted the enable-decorators branch April 1, 2019 19:11
@kategengler kategengler mentioned this pull request Apr 11, 2019
Closed
15 tasks
@kategengler kategengler mentioned this pull request Apr 26, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@mike-north mike-north mike-north approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pzuraq @auvipy @rwjblue @Turbo87 @mike-north