[BUGFIX] Asserts when users attempt to set a shadowed value with Ember.set #19198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
bugfix/assert-when-setting-shadowed-property
branch
from
fdb1296
to
deb7aed
Compare
rwjblue
reviewed
Oct 15, 2020
| `Attempted to set \`${toString( | ||
| obj | ||
| )}.${keyName}\` using Ember.set(), but the property was a computed or tracked property that was shadowed by another property declaration. This can happen if you defined a tracked or computed property on a parent class, and then redefined it on a subclass.`, | ||
| name && (name.indexOf('CPSETTER_FUNCTION') !== -1 || name.indexOf('TRACKED_SETTER') !== -1) |
There was a problem hiding this comment.
Instead of indexing the name can we keep the weakset system (for debug only)?
There was a problem hiding this comment.
we can, it's just more of a pain to maintain. FWIW, this is what we did before we actually needed to rely on the behavior in prod
There was a problem hiding this comment.
also FWIW what we do for CPGETTER_FUNCTION: https://github.com/emberjs/ember.js/blob/bugfix/assert-when-setting-shadowed-property/packages/@ember/-internals/metal/lib/decorator.ts#L103
pzuraq
force-pushed
the
bugfix/assert-when-setting-shadowed-property
branch
from
deb7aed
to
0b0b1be
Compare
pzuraq
force-pushed
the
bugfix/assert-when-setting-shadowed-property
branch
from
0b0b1be
to
41b68b7
Compare
|
@rwjblue the issue with local assignment is there's no way for us to intercept that, it's actually impossible to do unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents users from setting a value if it's been shadowed, which can cause inconsistencies in behavior.