Bugfix: new loader feature was missing cache update

#20675 included a small addition to the basic AMD loader that ships inside ember-source for use in node. I added the ability to register a whole preexisting module. But when using that feature, we don't stick the results into the seen cache, so subsequent requests will see an empty module.
emberjs · May 13, 2024 · b1ae249 · b1ae249
1 parent fbe8738
commit b1ae249
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/loader/lib/index.js b/packages/loader/lib/index.js
@@ -74,7 +74,7 @@ var define, require;
 
     var result = callback.apply(this, reified);
     if (!deps.includes('exports') || result !== undefined) {
-      exports = result;
+      exports = seen[name] = result;
     }
 
     return exports;

diff --git a/tests/node/template-compiler-test.js b/tests/node/template-compiler-test.js
@@ -34,6 +34,14 @@ QUnit.module('ember-template-compiler.js', function () {
       assert.notEqual(typeof templateCompiler._Ember.ENV, null, '_Ember.ENV is not null');
     });
 
+    QUnit.test('_Ember.ENV (private API used by ember-cli-htmlbars) is stable', function (assert) {
+      assert.strictEqual(
+        templateCompiler._Ember.ENV,
+        templateCompiler._Ember.ENV,
+        '_Ember.ENV is stable'
+      );
+    });
+
     QUnit.test(
       'can access _Ember.FEATURES (private API used by ember-cli-htmlbars)',
       function (assert) {